Expose request timing#735
Merged
Merged
Conversation
hadley
reviewed
Jun 13, 2025
Member
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Thanks for working on this! I've provided some detailed feedback below just to get everything perfect 😄
Contributor
Author
|
Thanks for the comments! I've made some doc changes. The CI failure doesn't seem to be related. |
hadley
reviewed
Jun 16, 2025
| @@ -0,0 +1,4 @@ | |||
| test_that("can extract request timing", { | |||
Member
There was a problem hiding this comment.
@arcresu I figured it was easier to just make the change than try to explain it further. And now that I've done it, I can express what I was picking up on more clearly: it's worth partitioning your test into two pieces, one that tests we are correctly setting the values, and one that tests we are correctly getting the values.
Member
|
Thanks for your help with this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new function to expose request timing information from curl. Closes #725.
I wasn't sure about the need to validate the timing vector's type when creating the response but had a shot at that.
The R library
curldoesn't document the specific elements of the timing vector, but they do correspond to the naming of the enum in libcurl so I thought it was useful to mention that.